Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test IfInterface #1574

Merged
merged 2 commits into from
Dec 5, 2024
Merged

test IfInterface #1574

merged 2 commits into from
Dec 5, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Dec 5, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Bigtest Unit Test Results

192 tests  ±0   187 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 8498e73. ± Comparison against base commit a99341c.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both. 
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content

Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_131_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Jest Unit Test Results

  1 files  ±0   58 suites  +1   1m 31s ⏱️ -1s
353 tests +2  353 ✅ +2  0 💤 ±0  0 ❌ ±0 
356 runs  +2  356 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 8498e73. ± Comparison against base commit a99341c.

♻️ This comment has been updated with latest results.

@zburke zburke requested a review from JohnC-80 December 5, 2024 15:37
@zburke
Copy link
Member Author

zburke commented Dec 5, 2024

@JohnC-80 , I reimplemented this component so it functions with render-props, for parity with IfPermission. Any objections/concerns?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zburke zburke merged commit bb49c80 into master Dec 5, 2024
16 checks passed
@zburke zburke deleted the test-IfInterface branch December 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnC-80 JohnC-80 JohnC-80 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zburke @JohnC-80